Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow analysis tooling #1866

Closed
SWilson4 opened this issue Jul 26, 2024 · 1 comment
Closed

Add CI workflow analysis tooling #1866

SWilson4 opened this issue Jul 26, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Issue for new contributors help wanted Asking for support from non-core team

Comments

@SWilson4
Copy link
Member

This will help to prevent (potentially serious) errors of a similar nature to #1863. Suggestions include actionlint and poutine.

Reported by @trailofbits in Week 1 of their audit of liboqs.
This was referenced Jul 26, 2024
Open
Merged
@jplomas jplomas mentioned this issue Aug 3, 2024
Closed
@baentsch baentsch added enhancement New feature or request help wanted Asking for support from non-core team good first issue Issue for new contributors labels Aug 9, 2024
@SWilson4 SWilson4 moved this from Todo to In Progress in liboqs planning Aug 9, 2024
jplomas added a commit to jplomas/liboqs that referenced this issue Sep 10, 2024
@jplomas
Check workflows for issues during CI
d27fe4c 
This PR adds an Actionlint workflow to validate GH actions as per open-quantum-safe#1866

This is an updated version of PR open-quantum-safe#1880, taking into account the discussion on that contribution.

Signed-off-by: JP Lomas <jp@theqrl.org>
@jplomas jplomas mentioned this issue Sep 10, 2024
Merged
SWilson4 added a commit that referenced this issue Sep 11, 2024
@jplomas @SWilson4
Check workflows for issues during CI (#1916)
a7bfc8d 
* Check workflows for issues during CI

This PR adds an Actionlint workflow to validate GH actions as per #1866

This is an updated version of PR #1880, taking into account the discussion on that contribution.

Signed-off-by: JP Lomas <jp@theqrl.org>

* CONTRIBUTING.md update

Documents actionlint use as part of CI basic workflow including instructions of running locally.

Signed-off-by: JP Lomas <jp@theqrl.org>

* Update .github/workflows/basic.yml

Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
Signed-off-by: JP Lomas <jp.lomas@gmail.com>

---------

Signed-off-by: JP Lomas <jp@theqrl.org>
Signed-off-by: JP Lomas <jp.lomas@gmail.com>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4
Copy link
Member Author

Fixed by #1916.

@github-project-automation github-project-automation bot moved this from In Progress to Done in liboqs planning Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issue for new contributors help wanted Asking for support from non-core team
Projects
liboqs planning
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWilson4 @baentsch