Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Fix #1735

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Document Fix #1735

merged 1 commit into from
Apr 4, 2024

Conversation

pi-314159
Copy link
Member

Update links, fix typos, and make the README clearer

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@pi-314159 pi-314159 requested a review from dstebila as a code owner March 25, 2024 07:10
baentsch
baentsch approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This change IMO brings back BoringSSL as a supported sub project: Thanks for that committment, @pi-314159 !

@pi-314159
Copy link
Member Author

@dstebila Could you take a look at this doc update? Thank you!

@pi-314159 pi-314159 mentioned this pull request Apr 2, 2024
Merged
@pi-314159
Copy link
Member Author

@baentsch Could you retry the merge? DCO should be fixed now.

@baentsch
Copy link
Member

baentsch commented Apr 3, 2024

@baentsch Could you retry the merge? DCO should be fixed now.

Thanks for the DCO fix. Will merge after #1743 landed (I hate CI failing during PR).

@baentsch
Copy link
Member

baentsch commented Apr 3, 2024

Github CI seems to be in pretty bad shape right now. Would anyone in a non-EU timezone please retry as/when fixed, e.g., @praveksharma ?

SWilson4
SWilson4 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @pi-314159!

@pi-314159
Document Fix
3a43414 
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
@pi-314159
Copy link
Member Author

@SWilson4 Could you retry the merge?

@SWilson4 SWilson4 merged commit 7a6df81 into open-quantum-safe:main Apr 4, 2024
6 of 11 checks passed
@pi-314159 pi-314159 deleted the doc-fix-20240325 branch April 4, 2024 18:15
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@SWilson4 SWilson4 SWilson4 approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-314159 @baentsch @dstebila @SWilson4