Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict Windows platform support documentation [skip ci] #1762

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

baentsch
Copy link
Member

oqs-provider has been testing cygwin support also for liboqs. But this now fails for two reasons:

This PR therefore restricts stated Windows support to MSVC until a formal decision is taken to enhance Windows support beyond this (& adding CI in this project).

  • [no] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [no] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Thanks for taking the time to formalize this, @baentsch.

@baentsch baentsch merged commit 2bb1d25 into main Apr 23, 2024
2 checks passed
@baentsch baentsch deleted the mb-winsupport branch April 23, 2024 15:53
@baentsch
Copy link
Member Author

Fine with me. Thanks for taking the time to formalize this, @baentsch.

Not so much meant as formalization but reminder that OQS has a problem with cygwin (that may be worth while fixing as and if there'd be interest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants