Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm selection clarification #1784

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

beldmit
Copy link
Contributor

@beldmit beldmit commented May 7, 2024

Fixes #1781

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@beldmit beldmit requested a review from dstebila as a code owner May 7, 2024 08:14
@beldmit
Copy link
Contributor Author

beldmit commented May 7, 2024

Feel free to adjust my best English :)

Resolves: open-quantum-safe#1781
Signed-off-by: Dmitry Belyavskiy <beldmit@gmail.com>
@baentsch
Copy link
Member

baentsch commented May 7, 2024

Feel free to adjust my best English :)

Telling this to a Swiss/German sounds futile :-)

Thanks for the doc improvement! In the future, may I (or rather mother Earth) ask to tag documentation-only fixes with "[skip ci]" in the commit message to avoid some servers doing pointless tests?

@beldmit
Copy link
Contributor Author

beldmit commented May 7, 2024

@baentsch sure. Probably it's worth adding to the PR checklist? And I also can fail the md syntax (and regularly do)

@baentsch
Copy link
Member

baentsch commented May 7, 2024

can fail the md syntax

Good point. Are you aware of a (CI) tool catching this?

@beldmit
Copy link
Contributor Author

beldmit commented May 7, 2024

AFAIK openssl uses some ruby tool for this purpose

@beldmit
Copy link
Contributor Author

beldmit commented May 7, 2024

@baentsch baentsch merged commit a5ec23c into open-quantum-safe:main May 7, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What are STD algs?
3 participants