Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downstream CI trigger #1857

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Fix downstream CI trigger #1857

merged 5 commits into from
Jul 30, 2024

Conversation

SWilson4
Copy link
Member

Corrects my incorrect use of GitHub environment variables in #1849, making the downstream trigger pass.

I had previously tested the scripts locally but not in CI. The workflow for this PR is CI-tested here: https://github.com/open-quantum-safe/liboqs/actions/runs/10083919855

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

SWilson4 added 5 commits July 24, 2024 14:28
@SWilson4
Explicitly use secret
2cad01b 
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4
Trigger on all branches for testing purposes
4667284 
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4
fixup! Explicitly use secret
e5848d2 
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4
fixup! Explicitly use secret
b62d6c0 
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4
Revert "Trigger on all branches for testing purposes"
a890087 
This reverts commit 4667284.

Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@SWilson4 SWilson4 requested a review from dstebila as a code owner July 24, 2024 21:03
@SWilson4 SWilson4 requested review from ryjones and baentsch July 24, 2024 21:03
ryjones
ryjones approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@ryjones ryjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SWilson4 SWilson4 requested a review from praveksharma July 25, 2024 14:36
@SWilson4 SWilson4 merged commit 2acfd96 into main Jul 30, 2024
117 checks passed
@SWilson4 SWilson4 deleted the sw-fix-cci-trigger branch July 30, 2024 17:16
rtjk pushed a commit to rtjk/liboqs that referenced this pull request Aug 5, 2024
@SWilson4 @rtjk
Fix downstream CI trigger (open-quantum-safe#1857)
32f2618 
Explicitly use secret variable in GitHub Actions workflow

Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
Signed-off-by: rtjk <47841774+rtjk@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@ashman-p ashman-p ashman-p approved these changes

@ryjones ryjones ryjones approved these changes

@dstebila dstebila Awaiting requested review from dstebila

@praveksharma praveksharma Awaiting requested review from praveksharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SWilson4 @ryjones @ashman-p @baentsch