Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilithium5 not enabled #131

Closed
christianpaquin opened this issue Feb 1, 2023 · 3 comments
Closed

Dilithium5 not enabled #131

christianpaquin opened this issue Feb 1, 2023 · 3 comments

Comments

@christianpaquin
Copy link

Any reason why Dilithium5 is not enabled in the https://github.com/open-quantum-safe/openssh/blob/OQS-v8/oqs-template/generate.yml#L262 file? On purpose or oversight?

@dstebila
Copy link
Member

dstebila commented Feb 1, 2023

I don't recall any particular reason... unless we had also not enabled Dilithium5 in OpenSSL due to the constraints on the number of active signature schemes at one point in time...?

@baentsch
Copy link
Member

baentsch commented Feb 2, 2023

As far as I recall it was a random choice when doing #97: I enabled algs such as to get maximum test coverage while not adding too many algorithms (as I also think there's a limit in number of active sig algs): Thus, Dil5AES got enabled instead of Dil5. PR #132 changes this now in line with NIST decisions (also for Sphncs+).

@baentsch
Copy link
Member

baentsch commented Feb 2, 2023

Fixed by #132

@baentsch baentsch closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants