Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all algorithms #97

Merged
merged 9 commits into from
May 27, 2021
Merged

Adding all algorithms #97

merged 9 commits into from
May 27, 2021

Conversation

baentsch
Copy link
Member

Fixes #91.

McEliece & Rainbow need to be further debugged.
README needs updating (as to what (should) work and what doesn't).

@baentsch baentsch requested review from dstebila and xvzcf May 23, 2021 16:32
@dstebila
Copy link
Member

Code looks good, Michael, thanks. I made a mental note of the size increase to the one buffer.

What was the rationale for only enabling a few signature schemes? I don't recall there being constraints like in OpenSSL where we had bitmasks with a limited number of bits.

@xvzcf
Copy link

xvzcf commented May 26, 2021

What was the rationale for only enabling a few signature schemes? I don't recall there being constraints like in OpenSSL where we had bitmasks with a limited number of bits.

There is a similar constraint here in ssh-keyscan.c: 

KT_ECDSA_NISTP384_SPHINCS_HARAKA_192F_ROBUST;

@dstebila
Copy link
Member

What was the rationale for only enabling a few signature schemes? I don't recall there being constraints like in OpenSSL where we had bitmasks with a limited number of bits.

There is a similar constraint here in ssh-keyscan.c: 

KT_ECDSA_NISTP384_SPHINCS_HARAKA_192F_ROBUST;

Ah, okay, thanks! Looks like we've got a bit more space there—so far using only 18 of 64 bits—so would it be okay to include some of the level 1 schemes as well, since I think there will be interest in those?

@baentsch
Copy link
Member Author

would it be okay to include some of the level 1 schemes as well

Done with the latest commit. Will merge by COB today if I don't hear howls of protests.

@dstebila
Copy link
Member

would it be okay to include some of the level 1 schemes as well

Done with the latest commit. Will merge by COB today if I don't hear howls of protests.

Awesome, thanks Michael!

@baentsch baentsch merged commit cbbb4b5 into OQS-v8 May 27, 2021
@baentsch baentsch deleted the mb-v8test branch May 29, 2021 08:09
@baentsch baentsch mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants