-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oqs-test/try_connection.py tests what is in the README. #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the specific comments above.
Generally, using the regress data works, of course; but I'd then also suggest adding that
- host and client keys can be separately generated using
ssh-keygen
- configuration options (like port etc.) can either be set on the command line or in the respective
ssh_config
andsshd_config
files in theregress
folder.
Also, if the whole build documentation is reduced to running the build scripts, I'd suggest adding that "PREFIX" can be set to facilitate a specific oqs-openssh
install location: I can't imagine someone trying this will want to replace their system-wide ssh
right away :-)
Added a brief note about this.
Same here.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM.
No description provided.