Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove boringssl interop #417

Merged
merged 1 commit into from
Dec 21, 2022
Merged

remove boringssl interop #417

merged 1 commit into from
Dec 21, 2022

Conversation

baentsch
Copy link
Member

Fixes #416

  • [no] documentation is added or updated
  • tests are added or updated

@baentsch baentsch marked this pull request as ready for review December 20, 2022 07:57
@xvzcf
Copy link

xvzcf commented Dec 20, 2022

We could also just remove the oqs-interop-test directory if we're removing this job.

@baentsch
Copy link
Member Author

We could also just remove the oqs-interop-test directory if we're removing this job.

Well, my intention was not to completely remove this test capability, just to move it out of the critical (CI) path. What about removing it here/in oqs-openssl when it has been added to oqs-boringssl?

@xvzcf
Copy link

xvzcf commented Dec 20, 2022

Sure, sounds good.

@baentsch baentsch merged commit 38e12f1 into OQS-OpenSSL_1_1_1-stable Dec 21, 2022
@baentsch baentsch deleted the mb-removeboringinterop branch December 21, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila dstebila approved these changes

@christianpaquin christianpaquin Awaiting requested review from christianpaquin

@xvzcf xvzcf Awaiting requested review from xvzcf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove boringssl interop testing
3 participants
@baentsch @xvzcf @dstebila