Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged 1.1.1u #453

Conversation

christianpaquin
Copy link

Merged changes from upstream 1.1.1u release.

@christianpaquin
Copy link
Author

@dstebila, CI says my job is on hold (for the last 19h). Do you know what's going on?

@dstebila
Copy link
Member

dstebila commented Jun 8, 2023

I've clicked approve now, so it's going. Not sure why it wasn't auto-approved for you. If it happens again, just ping me and I'll click approve; will need to investigate more if it keeps happening.

@baentsch baentsch merged commit 70d83ca into open-quantum-safe:OQS-OpenSSL_1_1_1-stable Jun 10, 2023
@baentsch
Copy link
Member

I've clicked approve now, so it's going. Not sure why it wasn't auto-approved for you. If it happens again, just ping me and I'll click approve; will need to investigate more if it keeps happening.

The reason is this approval step:

- cond-testapproval:
requires:
- ubuntu-static_oqs-static_ossl
when:
equal: [ false , << pipeline.parameters.run_downstream_tests >> ]
type: approval

It had been added to eliminate unnecessary CI runs -- and succeeded in doing so in about 40% of cases if I'm looking at the build history. But given that we now hopefully eliminate running this over and over again we could also drop this instruction after having done a final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants