New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify version `3.1` while installing OpenSSL using brew. #217

Merged

baentsch merged 1 commit into open-quantum-safe:main from thb-sb:3.1

Jul 18, 2023

Commits on Jul 18, 2023

Specify version 3.1 while installing OpenSSL using brew.

Right now, the [CircleCI job](https://app.circleci.com/pipelines/github/open-quantum-safe/oqs-provider/696/workflows/46170fbf-b924-490c-8196-283cff0dd767/jobs/1521)
on macOS uses OpenSSL 3.0.1:

> Warning: openssl@3 3.0.1 is already installed and up-to-date.
> To reinstall 3.0.1, run:
>  brew reinstall openssl@3

> -- Found OpenSSL: /usr/local/opt/openssl@3/lib/libcrypto.dylib (found suitable version "3.0.1", minimum required is "3.0")

However, OpenSSL 3.0.1 seems broken:

https://github.com/open-quantum-safe/oqs-provider/blob/5250576fc6384af40c3d0d8b04ee5d9675ce7721/scripts/runtests.sh#L139-L143

This leads to the following [no-op test](https://app.circleci.com/pipelines/github/open-quantum-safe/oqs-provider/696/workflows/46170fbf-b924-490c-8196-283cff0dd767/jobs/1521?invite=true#step-106-13):

```
Test setup:
LD_LIBRARY_PATH=/usr/local/opt/openssl@3/lib
OPENSSL_APP=/usr/local/opt/openssl@3/bin/openssl
OPENSSL_CONF=/Users/distiller/project/scripts/openssl-ca.cnf
OPENSSL_MODULES=/Users/distiller/project/_build/lib
DYLD_LIBRARY_PATH=:/Users/distiller/project/.local/lib:/usr/local/opt/openssl@3/lib
No OQS-OpenSSL111 interop test because of absence of docker
Version information:
error registering dilithium2 with no hash
OpenSSL 3.0.1 14 Dec 2021 (Library: OpenSSL 3.0.1 14 Dec 2021)
error registering dilithium2 with no hash
Skipping testing of buggy OpenSSL 3.0.1

CircleCI received exit code 0
```

This commit tells homebrew to install at least OpenSSL `3.1`.

This change should allow `scripts/runtests.sh` to fully run again on macOS.

thb-sb committed Jul 18, 2023