Fix a missing -DOQS_PROVIDER_BUILD_STATIC=ON in CircleCI build static jobs.
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic jobs. A `-DOQS_PROVIDER_BUILD_STATIC=ON` was missing on two jobs (one for linux and one for macOS). This commit fixes that issue, and also adds a test to verify that `oqsprovider.a` was built if static build was requested.
ghost
requested a review
from 
ghost
mentioned this pull request
baentsch
approved these changes
Aug 31, 2023
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
…ic jobs. (open-quantum-safe#242) A `-DOQS_PROVIDER_BUILD_STATIC=ON` was missing on two jobs (one for linux and one for macOS). This commit fixes that issue, and also adds a test to verify that `oqsprovider.a` was built if static build was requested. Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
-DOQS_PROVIDER_BUILD_STATIC=ONwas missing on two jobs (one for linux and one for macOS).This commit fixes that issue, and also adds a test to verify that
oqsprovider.awas built if static build was requested.