CI & cmake changes #263
CI & cmake changes #263
Conversation
There was a problem hiding this comment.
NB: The ci change in this commit rely on my pr branch #256. I'm not sure whether should I make pr directly or just wait upstream to merged #256 then make this pr.
I'm not quite sure what you mean: Does #263 add to & improve the changes in #256? If so, we could simply close #256 and only merge #263, right? I was holding back #256 because of your final comment "Not final solution".
Otherwise things LGTM with two single comments where I'd appreciate feedback to properly understand things. Also waiting for CI to complete. Thanks very much for this work!
Yes. I will replace the lines +238 to +241 myself |
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es> Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es> Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es>
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es> Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es> Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
* Fix OQS_ADDL_SOCKET_LIBS setting for cmake * Test Windows 2019 with VS 16 2019 * Add path for VS * Avoid openssl cache conflict * Add build type into matrix --------- Co-authored-by: a <a@cre.es> Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Fully implement CI jobs for building under VS environment
Align the cmake test file with the VS generator.
NB: The ci change in this commit rely on my pr branch #256. I'm not sure whether should I make pr directly or just wait upstream to merged #256 then make this pr.