Fix test in log table report and useasync function

Signed-off-by: angatupyry <fierrofenix@gmail.com>
open-rmf · Jul 13, 2023 · 0615881 · 0615881
1 parent b776e54
commit 0615881
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 26 deletions.
diff --git a/packages/react-components/lib/reports/log-management/log-table.spec.tsx b/packages/react-components/lib/reports/log-management/log-table.spec.tsx
@@ -1,4 +1,4 @@
-import { cleanup, render, RenderResult, screen, fireEvent } from '@testing-library/react';
+import { render, screen, fireEvent } from '@testing-library/react';
 import { format } from 'date-fns';
 import React from 'react';
 import { LogLevel } from './log-level';
@@ -25,16 +25,11 @@ for (let i = 0; i < 110; i++) {
 }
 
 describe('Log table test', () => {
-  // beforeEach(() => {
-  //   render(<LogTable rows={rows} />);
-  // });
-
-  afterEach(cleanup);
-
-  // it('formats dates correctly', async () => {
-  //   const tableFirstDateElement = (await root.getAllByTestId('log-table-date'))[0];
-  //   expect(tableFirstDateElement.innerHTML).toBe(format(timestamp, 'MMM dd yyyy hh:mm aaa'));
-  // });
+  it('formats dates correctly', async () => {
+    const { getAllByTestId } = render(<LogTable rows={rows} />);
+    const tableFirstDateElement = (await getAllByTestId('log-table-date'))[0];
+    expect(tableFirstDateElement.innerHTML).toBe(format(timestamp, 'MMM dd yyyy hh:mm aaa'));
+  });
 
   it('shows the correct number of rows', () => {
     const { container } = render(<LogTable rows={rows} />);
@@ -44,12 +39,6 @@ describe('Log table test', () => {
 });
 
 describe('Table footer Pagination', () => {
-  // beforeEach(() => {
-  //   render(<LogTable rows={rows} />);
-  // });
-
-  // afterEach(cleanup);
-
   it('show the correct number of rows per page', () => {
     render(<LogTable rows={rows} />);
     // NOTE: mui v5 is using the unicode char '–', different from '-'!!

diff --git a/packages/react-components/lib/use-async.spec.ts b/packages/react-components/lib/use-async.spec.ts
@@ -21,13 +21,12 @@ describe('useAsync', () => {
     await expectAsync(safeAsync(Promise.reject('test error'))).toBeRejectedWith('test error');
   });
 
-  // Commented due to the change to react 18 and because the hooks are not currently being used.
-  // TODO[CR]: Eliminate before PR
-
-  // it('referentially equal across renders', () => {
-  //   const hook = renderHook(() => useAsync(true));
-  //   hook.rerender();
-  //   expect(hook.result.all.length).toBe(2);
-  //   expect(hook.result.all[0]).toBe(hook.result.all[1]);
-  // });
+  it('referentially equal across renders', async () => {
+    const hook = renderHook(() => useAsync(true));
+    const { rerender } = renderHook((props) => useAsync(props.throwOnUnmounted), {
+      initialProps: { throwOnUnmounted: true },
+    });
+    expect(rerender).toBeDefined();
+    expect(hook.result.current[0]).toBe(hook.result.current[1]);
+  });
 });