Skip to content

Commit

Permalink
simplify getting started setup
Browse files Browse the repository at this point in the history
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
  • Loading branch information
koonpeng committed Sep 5, 2024
1 parent 0f4897d commit 658930e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 15 deletions.
17 changes: 5 additions & 12 deletions packages/rmf-dashboard-framework/docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,13 @@ git clone --depth 1 https://github.com/open-rmf/rmf-web
```

<!-- TODO(koonpeng): not needed after package is published -->
Add modify the following to resolve `rmf-dashboard-framework` as if it is installed from npmjs.

pnpm-workspace.yaml (create if not exist)
```yaml
packages:
- "."
- "rmf-web/**/*"
```
Modify the following to resolve `rmf-dashboard-framework` as if it is installed from npmjs.

package.json
```
"dependencies": {
...
"rmf-dashboard-framework": "workspace:*"
"rmf-dashboard-framework": "rmf-web/packages/rmf-dashboard-framework"
}
```

Expand All @@ -51,9 +44,9 @@ tsconfig.app.json
Finally install and build the deps

```bash
# TODO(koonpeng): -w flag not needed after rmf-dashboard-framework is published
pnpm install --filter basic-dashboard...
pnpm --filter basic-dashboard^... build
cd rmf-web
pnpm install --filter=rmf-dashboard-framework...
pnpm --filter=rmf-dashboard-framework^... build
```

### Creating a Basic Dashboard
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import { DashboardThemes } from './theme';

const DefaultAlertDuration = 2000;

export interface DashboardHome {}

export interface DashboardTab {
name: string;
route: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/rmf-dashboard-framework/src/micro-apps/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { Suspense } from 'react';
import { useAppController } from 'rmf-dashboard-framework/hooks/use-app-controller';

import { Window, WindowProps } from '../components/window';
import { useAppController } from '../hooks/use-app-controller';
import { useSettings } from '../hooks/use-settings';
import { Settings } from '../services/settings';

Expand Down

0 comments on commit 658930e

Please sign in to comment.