Skip to content

Commit

Permalink
Using the same terminology between edit and delete.
Browse files Browse the repository at this point in the history
Signed-off-by: angatupyry <fierrofenix@gmail.com>
  • Loading branch information
Angatupyry committed Sep 18, 2023
1 parent 9173dc1 commit c6f3e13
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 0 additions & 2 deletions packages/dashboard/src/components/tasks/task-schedule.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ export const SchedulerTask = () => {
currentValue={EventScopes.CURRENT}
allValue={EventScopes.ALL}
value={value}
deleting={false}
onChange={onChange}
/>
</ConfirmationDialog>
Expand Down Expand Up @@ -331,7 +330,6 @@ export const SchedulerTask = () => {
currentValue={EventScopes.CURRENT}
allValue={EventScopes.ALL}
value={eventScope}
deleting={true}
onChange={(event: React.ChangeEvent<HTMLInputElement>) =>
setEventScope(event.target.value)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@ interface EventEditDeletePopupProps {
currentValue: string;
allValue: string;
value: string;
deleting: boolean;
onChange: (event: React.ChangeEvent<HTMLInputElement>) => void;
}

export function EventEditDeletePopup({
currentValue,
allValue,
value,
deleting,
onChange,
}: EventEditDeletePopupProps): JSX.Element {
return (
Expand All @@ -24,15 +22,11 @@ export function EventEditDeletePopup({
value={value}
onChange={onChange}
>
<FormControlLabel
value={currentValue}
control={<Radio />}
label={`${deleting ? 'This event' : 'Edit this instance'}`}
/>
<FormControlLabel value={currentValue} control={<Radio />} label={'This event'} />
<FormControlLabel
value={allValue}
control={<Radio />}
label={`${deleting ? 'All events' : 'Edit series'}`}
label={'All events in this schedule'}
/>
</RadioGroup>
</FormControl>
Expand Down

0 comments on commit c6f3e13

Please sign in to comment.