Rename props to be more descriptive

Signed-off-by: angatupyry <fierrofenix@gmail.com>
open-rmf · Sep 18, 2023 · cfb4a26 · cfb4a26
1 parent 644583b
commit cfb4a26
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/dashboard/src/components/tasks/task-schedule.tsx b/packages/dashboard/src/components/tasks/task-schedule.tsx
@@ -78,7 +78,7 @@ export const TaskSchedule = () => {
   const [calendarEvents, setCalendarEvents] = React.useState<ProcessedEvent[]>([]);
   const [openDeleteScheduleDialog, setOpenDeleteScheduleDialog] = React.useState(false);
   const [openCreateTaskForm, setOpenCreateTaskForm] = React.useState(false);
-  const [selectedSchedule, setSelectedSchedule] = React.useState<Schedule>({
+  const [scheduleToEdit, setScheduleToEdit] = React.useState<Schedule>({
     startOn: new Date(),
     days: [false, false, false, false, false, false, false],
     until: undefined,
@@ -146,9 +146,9 @@ export const TaskSchedule = () => {
             throw new Error('No task found');
           }
           setCurrentScheduledTask(task);
-          setSelectedSchedule(apiScheduleToSchedule(task.schedules));
+          setScheduleToEdit(apiScheduleToSchedule(task.schedules));
           if (eventScope === EventScopes.CURRENT) {
-            setSelectedSchedule(scheduleWithSelectedDay(task.schedules, exceptDateRef.current));
+            setScheduleToEdit(scheduleWithSelectedDay(task.schedules, exceptDateRef.current));
           }
           AppEvents.refreshTaskApp.next();
           scheduler.close();
@@ -288,7 +288,7 @@ export const TaskSchedule = () => {
           pickupPoints={pickupPoints}
           dropoffPoints={dropoffPoints}
           open={openCreateTaskForm}
-          currentSchedule={selectedSchedule}
+          scheduleToEdit={scheduleToEdit}
           requestTask={currentScheduleTask?.task_request}
           onClose={() => {
             setOpenCreateTaskForm(false);

diff --git a/packages/react-components/lib/tasks/create-task.tsx b/packages/react-components/lib/tasks/create-task.tsx
@@ -672,7 +672,7 @@ export interface CreateTaskFormProps
   pickupPoints?: Record<string, string>;
   dropoffPoints?: Record<string, string>;
   favoritesTasks?: TaskFavorite[];
-  currentSchedule?: Schedule;
+  scheduleToEdit?: Schedule;
   requestTask?: TaskRequest;
   submitTasks?(tasks: TaskRequest[], schedule: Schedule | null): Promise<void>;
   tasksFromFile?(): Promise<TaskRequest[]> | TaskRequest[];
@@ -693,7 +693,7 @@ export function CreateTaskForm({
   pickupPoints = {},
   dropoffPoints = {},
   favoritesTasks = [],
-  currentSchedule,
+  scheduleToEdit,
   requestTask,
   submitTasks,
   tasksFromFile,
@@ -734,15 +734,15 @@ export function CreateTaskForm({
   const taskRequest = taskRequests[selectedTaskIdx];
   const [openSchedulingDialog, setOpenSchedulingDialog] = React.useState(false);
   const [schedule, setSchedule] = React.useState<Schedule>(
-    currentSchedule ?? {
+    scheduleToEdit ?? {
       startOn: new Date(),
       days: [true, true, true, true, true, true, true],
       until: undefined,
     },
   );
   const [atTime, setAtTime] = React.useState(new Date());
   const [scheduleUntilValue, setScheduleUntilValue] = React.useState<string>(
-    currentSchedule?.until ? ScheduleUntilValue.ON : ScheduleUntilValue.NEVER,
+    scheduleToEdit?.until ? ScheduleUntilValue.ON : ScheduleUntilValue.NEVER,
   );
 
   const handleScheduleUntilValue = (event: React.ChangeEvent<HTMLInputElement>) => {
@@ -1139,13 +1139,13 @@ export function CreateTaskForm({
               className={classes.actionBtn}
               onClick={() => setOpenSchedulingDialog(true)}
             >
-              {currentSchedule ? 'Edit schedule' : 'Add to Schedule'}
+              {scheduleToEdit ? 'Edit schedule' : 'Add to Schedule'}
             </Button>
             <Button
               variant="contained"
               type="submit"
               color="primary"
-              disabled={submitting || !formFullyFilled || currentSchedule !== undefined}
+              disabled={submitting || !formFullyFilled || scheduleToEdit !== undefined}
               className={classes.actionBtn}
               aria-label={submitText}
               onClick={handleSubmitNow}