Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forms look nicer #723

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Make forms look nicer #723

merged 3 commits into from
Jul 6, 2023

Conversation

aaronchongth
Copy link
Member

What's new

  • Fixed sizing and spacing of forms using material ui spacing and grid containers

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #723 (0e9d5bc) into main (b39540c) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   56.37%   56.30%   -0.07%     
==========================================
  Files         293      293              
  Lines        6966     6981      +15     
  Branches      956      943      -13     
==========================================
+ Hits         3927     3931       +4     
- Misses       2847     2858      +11     
  Partials      192      192              
Flag Coverage Δ
dashboard 18.52% <ø> (+0.06%) ⬆️
react-components 57.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/react-components/lib/tasks/create-task.tsx 1.42% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth changed the title Fix/forms Make forms look nicer Jul 5, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!!

@aaronchongth aaronchongth merged commit be549a3 into main Jul 6, 2023
@aaronchongth aaronchongth deleted the fix/forms branch July 6, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants