Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ends on scheduling recurrences #728

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • End date added for recurring tasks
  • Ending date is inclusive

How test it?

  • Create a scheduled task.
  • Choose the ON option under "Ends" and set an until date.
  • The scheduling screen should show only tasks up to the chosen date.
chrome-capture-2023-6-21.webm

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #728 (0d9ef83) into main (fd92cb3) will decrease coverage by 0.11%.
The diff coverage is 14.81%.

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   56.37%   56.26%   -0.11%     
==========================================
  Files         295      295              
  Lines        7028     7047      +19     
  Branches      943      946       +3     
==========================================
+ Hits         3962     3965       +3     
- Misses       2874     2890      +16     
  Partials      192      192              
Flag Coverage Δ
api-server 82.73% <100.00%> (ø)
dashboard 18.52% <0.00%> (-0.01%) ⬇️
react-components 57.62% <16.66%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/appbar.tsx 30.47% <0.00%> (-0.15%) ⬇️
...ackages/react-components/lib/tasks/create-task.tsx 2.34% <16.66%> (+0.92%) ⬆️
...pi_server/models/tortoise_models/scheduled_task.py 87.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working! This is awesome, thanks @Angatupyry!

I've left 1 review comment regarding the form, and how I would suggest shuffling things around and aligning items. Let me know what you think

packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

@aaronchongth aaronchongth merged commit c67ffb8 into main Jul 25, 2023
5 checks passed
@aaronchongth aaronchongth deleted the feature/ends-on-scheduling-recurrences branch July 25, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants