Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display adhooc or scheduled #731

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • Display on task queue whether task was scheduled or ad-hoc
  • For now, automatic robot tasks do not have a distinct icon due we have not a way to differential it from real users since the name is the ROS 2 node name

chrome-capture-2023-6-31

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Angatupyry <fierrofenix@gmail.com>
Signed-off-by: Angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #731 (17b513d) into main (ac76ae9) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   54.68%   54.67%   -0.01%     
==========================================
  Files         261      261              
  Lines        6472     6478       +6     
  Branches      836      857      +21     
==========================================
+ Hits         3539     3542       +3     
- Misses       2795     2798       +3     
  Partials      138      138              
Flag Coverage Δ
dashboard 18.59% <ø> (ø)
react-components 51.60% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/react-components/lib/tasks/create-task.tsx 2.34% <0.00%> (-0.01%) ⬇️
...react-components/lib/tasks/task-table-datagrid.tsx 59.57% <50.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great! Thanks for adjusting the width of the table too. I left some minor comments on how it looks, but the implementation works great!

…nd add Tooltip to the icons

Signed-off-by: Angatupyry <fierrofenix@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@aaronchongth aaronchongth merged commit 0aa093d into main Aug 4, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the feature/display-adhooc-or-scheduled branch August 4, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants