Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react 18 warning and show appbar tab correctly #732

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • Fix react 18 warning. (React.render)
  • Fix the correct functioning of the tabs

Before

  • Appbar tab displays the wrong tab

Screenshot from 2023-08-01 11-46-30

  • React 18 warning

Screenshot from 2023-08-01 11-46-12

After changes

  • The appbar displays the selected tab correctly.
chrome-capture-2023-7-1.webm
  • The warning no longer appears.
    Screenshot from 2023-08-01 11-48-06

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Angatupyry <fierrofenix@gmail.com>
Signed-off-by: Angatupyry <fierrofenix@gmail.com>
Signed-off-by: Angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #732 (11bd572) into main (ac76ae9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   54.68%   54.68%           
=======================================
  Files         261      261           
  Lines        6472     6472           
  Branches      836      836           
=======================================
  Hits         3539     3539           
  Misses       2795     2795           
  Partials      138      138           
Flag Coverage Δ
dashboard 18.59% <ø> (ø)
react-components 51.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/appbar.tsx 32.03% <ø> (ø)
...act-components/lib/map/trajectory-time-control.tsx 29.16% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth
Copy link
Member

🤦 Sorry I didn't catch it in the migration review. Thanks for the fix!

@aaronchongth aaronchongth merged commit 87bcb6f into main Aug 2, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the fix/react18-migration branch August 2, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants