Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panning rotation issue #737

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

aaronchongth
Copy link
Member

What's new

Related to #734

  • Use orthographic camera by default
  • Target of orthographic camera set to 1km below origin, this fixes the re-orientation when we pan
  • Changing left click to panning
  • Disabling all other mouse interations (rotation and dolly)
  • Using a fixed zoom of 20 for now, this should be configurable later on

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

…panning, changing left click to pan, disabling other orbit controls

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@Angatupyry Angatupyry merged commit 810f3d0 into feature/threefiber-map Aug 18, 2023
1 of 3 checks passed
@Angatupyry Angatupyry deleted the fix/panning-rotation branch August 18, 2023 00:44
@Angatupyry
Copy link
Collaborator

This is awesome!!!
Thanks, @aaronchongth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants