Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom and admin tabs #744

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • Tabs and routes are removed

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #744 (9df2ea8) into deploy/hammer (d755f14) will increase coverage by 0.01%.
Report is 1 commits behind head on deploy/hammer.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           deploy/hammer     #744      +/-   ##
=================================================
+ Coverage          54.65%   54.66%   +0.01%     
=================================================
  Files                263      263              
  Lines               6528     6523       -5     
  Branches             862      860       -2     
=================================================
- Hits                3568     3566       -2     
+ Misses              2820     2817       -3     
  Partials             140      140              
Flag Coverage Δ
dashboard 18.39% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app.tsx 0.00% <ø> (ø)
packages/dashboard/src/components/appbar.tsx 31.84% <ø> (-0.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@aaronchongth aaronchongth merged commit 58db1e9 into deploy/hammer Aug 24, 2023
3 checks passed
@aaronchongth aaronchongth deleted the feature/remove-custom-and-admin-tabs branch August 24, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants