Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing handler delivery task description #745

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

aaronchongth
Copy link
Member

What's new

Fixes to broken delivery task request

  • re-introduced the handler field for pickup and dropoff
  • reverted back to getPlace function call, but changed the implementation to return information for all types of named places
  • create-task now accepts a Record<string, string> for pickup and dropoff points, as it maps the name of the waypoint to the name of the handler
  • checks for valid pickup and dropoff waypoint names and handler names before triggering change, to prevent crashes in the backend
  • fixed a minor typo where modifying dropoff location changes pickup locations too

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #745 (ea5550a) into main (1412804) will decrease coverage by 0.02%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   54.52%   54.50%   -0.02%     
==========================================
  Files         263      263              
  Lines        6548     6550       +2     
  Branches      865      871       +6     
==========================================
  Hits         3570     3570              
- Misses       2838     2840       +2     
  Partials      140      140              
Flag Coverage Δ
dashboard 18.26% <10.52%> (-0.11%) ⬇️
react-components 52.08% <0.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/react-components/lib/place.ts 15.78% <0.00%> (+5.44%) ⬆️
...ackages/react-components/lib/tasks/create-task.tsx 2.38% <0.00%> (ø)
packages/dashboard/src/components/appbar.tsx 29.41% <10.52%> (-1.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, Aaron!

@aaronchongth aaronchongth merged commit 09f0466 into main Aug 24, 2023
4 checks passed
@aaronchongth aaronchongth deleted the fix/delivery branch August 24, 2023 15:51
This was referenced Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants