Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/tasks #750

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Hammer/tasks #750

merged 4 commits into from
Aug 30, 2023

Conversation

aaronchongth
Copy link
Member

What's new

  • Support for
    • Delivery - Sequential Hunting
    • Delivery - Area Hunting
  • Removed all unused tasks
  • Refactored Delivery tasks

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

image

image

image

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #750 (a714a74) into deploy/hammer (de3a5ad) will increase coverage by 0.36%.
Report is 6 commits behind head on deploy/hammer.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           deploy/hammer     #750      +/-   ##
=================================================
+ Coverage          54.26%   54.62%   +0.36%     
=================================================
  Files                263      263              
  Lines               6583     6545      -38     
  Branches             875      864      -11     
=================================================
+ Hits                3572     3575       +3     
+ Misses              2871     2830      -41     
  Partials             140      140              
Flag Coverage Δ
dashboard 18.12% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/appbar.tsx 30.13% <ø> (+0.97%) ⬆️
...ackages/react-components/lib/tasks/create-task.tsx 2.76% <ø> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review August 30, 2023 07:37
@aaronchongth
Copy link
Member Author

Updated to contain configurable pickupZone
image

@aaronchongth aaronchongth merged commit ba4a61c into deploy/hammer Aug 30, 2023
2 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/tasks branch August 30, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant