-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App bar changes #753
App bar changes #753
Conversation
Signed-off-by: angatupyry <fierrofenix@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help! It looks like the project's logo size is 406 x 124, which makes the appbar thicker than usual. For this deployment branch, I think we can make our default logo the same height, and maximize our font size based on that. Let me know if you think that's a good idea
edit: feel free to merge in from deploy/hammer
too, to get #755 in, so the CI can run normally
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Codecov Report
@@ Coverage Diff @@
## deploy/hammer #753 +/- ##
==============================================
Coverage 54.26% 54.26%
==============================================
Files 263 263
Lines 6583 6584 +1
Branches 875 875
==============================================
+ Hits 3572 3573 +1
Misses 2871 2871
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resizing these items! I've added some changes based on your work for some other components too
What's new
Self-checks
Discussion