Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App bar changes #753

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • Increase the font size on the title bar
  • Change New Task button size

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! It looks like the project's logo size is 406 x 124, which makes the appbar thicker than usual. For this deployment branch, I think we can make our default logo the same height, and maximize our font size based on that. Let me know if you think that's a good idea

edit: feel free to merge in from deploy/hammer too, to get #755 in, so the CI can run normally

Signed-off-by: angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #753 (1ef3043) into deploy/hammer (de3a5ad) will increase coverage by 0.00%.
Report is 5 commits behind head on deploy/hammer.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           deploy/hammer     #753   +/-   ##
==============================================
  Coverage          54.26%   54.26%           
==============================================
  Files                263      263           
  Lines               6583     6584    +1     
  Branches             875      875           
==============================================
+ Hits                3572     3573    +1     
  Misses              2871     2871           
  Partials             140      140           
Flag Coverage Δ
dashboard 18.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/appbar.tsx 29.49% <100.00%> (+0.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resizing these items! I've added some changes based on your work for some other components too

@aaronchongth aaronchongth merged commit c452151 into deploy/hammer Aug 30, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the feature/increase-font-size-on-title-bar branch August 30, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants