Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support offline doc generation (#784) #786

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

aaronchongth
Copy link
Member

(cherry picked from commit 828171e)

What's new

  • Splitting cache and static
  • Allow generating api-server docs without internet access

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

* Support offline doc generation

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Splitting static from run

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* psql config to use static as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Change static to cache for cached files, serve bundle in static

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Creating the cache directory just in case it is not called from pnpm

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved bundle into package, fixed package_data invocation, use absolute path to bundles

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove rogue print statement

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 828171e)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #786 (04eaa15) into main (c1d78d2) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   52.95%   52.96%           
=======================================
  Files         268      268           
  Lines        6794     6797    +3     
  Branches      907      907           
=======================================
+ Hits         3598     3600    +2     
- Misses       3055     3056    +1     
  Partials      141      141           
Flag Coverage Δ
api-server 81.45% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/api-server/api_server/default_config.py 100.00% <ø> (ø)
packages/api-server/api_server/fast_io/__init__.py 77.08% <50.00%> (-0.39%) ⬇️
packages/api-server/api_server/app_config.py 83.72% <100.00%> (ø)
...ges/api-server/api_server/repositories/__init__.py 100.00% <100.00%> (ø)
...api-server/api_server/repositories/cached_files.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth merged commit 4e4e336 into main Sep 25, 2023
3 checks passed
@aaronchongth aaronchongth deleted the fix/split-cache-and-static branch September 25, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants