fix: allow using integers as id

open-rpc · Jul 25, 2019 · 2042f72 · 2042f72
1 parent 097c960
commit 2042f72
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/RequestManager.test.ts b/src/RequestManager.test.ts
@@ -96,12 +96,12 @@ describe("client-js", () => {
       const result = JSON.stringify([
         {
           jsonrpc: "2.0",
-          id: "0",
+          id: 0,
           result: "foo",
         },
         {
           jsonrpc: "2.0",
-          id: "1",
+          id: 1,
           result: "bar",
         },
       ]);

diff --git a/src/RequestManager.ts b/src/RequestManager.ts
@@ -2,7 +2,7 @@ import ITransport from "./transports/Transport";
 
 interface IJSONRPCRequest {
   jsonrpc: "2.0";
-  id: string;
+  id: string | number;
   method: string;
   params: any[] | object;
 }
@@ -14,7 +14,7 @@ interface IJSONRPCError {
 
 interface IJSONRPCResponse {
   jsonrpc: "2.0";
-  id: string; // can also be null
+  id: string | number; // can also be null
   result?: any;
   error?: IJSONRPCError;
 }
@@ -117,6 +117,7 @@ class RequestManager {
     const results = parsedData instanceof Array ? parsedData : [parsedData];
 
     results.forEach((response) => {
+      const id = typeof response.id === "string" ? response.id : response.id.toString();
       const promiseForResult = this.requests[response.id];
       if (promiseForResult === undefined) {
         throw new Error(