Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onData doesnt handle more than one callback #53

Closed
shanejonas opened this issue Jul 29, 2019 · 1 comment · Fixed by #63
Closed

onData doesnt handle more than one callback #53

shanejonas opened this issue Jul 29, 2019 · 1 comment · Fixed by #63
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Member

Describe the bug
calling onData more than once will clear the callback

To Reproduce
call onData more than once

Expected behavior
I should be able to call onData many places and have it call back when data arrives
@shanejonas shanejonas added the bug Something isn't working label Jul 29, 2019
shanejonas added a commit that referenced this issue Aug 22, 2019
@shanejonas
fix(transports): handle multiple onData callback
4628e6a 
fixes #53
@shanejonas shanejonas mentioned this issue Aug 22, 2019
Merged
shanejonas added a commit that referenced this issue Aug 22, 2019
@shanejonas
fix(transports): handle multiple onData callback
b125962 
fixes #53
openrpc-bastion added a commit that referenced this issue Aug 22, 2019
@openrpc-bastion
chore(release): 1.1.1 [skip ci]
0ad055b 
## [1.1.1](1.1.0...1.1.1) (2019-08-22)

### Bug Fixes

* **transports:** handle multiple onData callback ([b125962](b125962)), closes [#53](#53)
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transports): handle multiple onData callback open-rpc/client-js
2 participants
@shanejonas @openrpc-bastion