Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jsonrpc error instanceof #234

Merged
merged 3 commits into from
Dec 17, 2020
Merged

fix: jsonrpc error instanceof #234

merged 3 commits into from
Dec 17, 2020

Conversation

shanejonas
Copy link
Member

fixes #209

@shanejonas shanejonas self-assigned this Dec 17, 2020
@shanejonas shanejonas added the bug Something isn't working label Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #234 (dc2df42) into master (e3266e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          11       11           
  Lines         388      388           
  Branches       53       53           
=======================================
  Hits          383      383           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3266e6...dc2df42. Read the comment docs.

zcstarr
zcstarr approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent 🚢

@shanejonas shanejonas merged commit 86780d4 into master Dec 17, 2020
@shanejonas shanejonas deleted the fix/jsonrpc-error-instanceof branch December 17, 2020 17:34
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcstarr zcstarr zcstarr approved these changes

Assignees

@shanejonas shanejonas

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONRPCError cannot be caught with instanceof
3 participants
@shanejonas @openrpc-bastion @zcstarr