Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Exec race condition #40

Closed
wants to merge 2 commits into from
Closed

Fix: Exec race condition #40

wants to merge 2 commits into from

Conversation

Meldiron
Copy link
Contributor

If you create execution right after build, it tries to create container but that (for some reason) still exist from build. You get error

An internal curl error has occurred while starting runtime! Error Msg: Docker Error: docker: Error response from daemon: Conflict. The container name "/exc0-6504acaa254213470be0-6507566cd981c5675a7f" is already in use by container "3db20471263767d391a7a0d2929eca60be43349b700c84467ca4efeec2c4de34". You have to remove (or rename) that container to be able to reuse that name.
See 'docker run --help'.
Preparing for build ...
Building ...

added 13 packages, and audited 14 packages in 1s

2 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
Packing build ...
Build finished.
\nError Code: 500

To prevent this, we give exec container different name than build container with the suffix. That should fully separate those concerns, and not cause this troble.

@Meldiron
Copy link
Contributor Author

Closing in favour of appwrite/appwrite#6270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant