-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update DevCard design #3879
Conversation
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…sauced/app into feat/devcard-design-update
It looks like your test fails as part of the regular test suite, not the E2E tests. The unit/component tests aren't aware of the env vars that the Supabase client is looking for. I don't think the tests ever passed locally. I made them stop failing by adding the following to the vitest.config.ts. import { fileURLToPath } from "url";
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";
// https://vitejs.dev/config/
export default defineConfig({
plugins: [react()],
resolve: {
alias: {
components: fileURLToPath(new URL("./components", import.meta.url)),
lib: fileURLToPath(new URL("./lib", import.meta.url)),
helpers: fileURLToPath(new URL("./helpers", import.meta.url)),
img: fileURLToPath(new URL("./img", import.meta.url)),
},
},
test: {
include: ["./**/*.test.ts", "./**/*.test.tsx"],
globals: true,
environment: "jsdom",
+ env: {
+ NEXT_PUBLIC_SUPABASE_URL: "https://test.supabase.co",
+ NEXT_PUBLIC_SUPABASE_ANON_KEY: "test-anon-key",
+ },
},
}); Right now with the fix above, the tests run now, but fail with
I think a component test for a single DevCard makes more sense (shouldn't be calling supabaseClient) and test the dev card page which has the dev card carousel in an E2E test. Anyway, we can chat about it Monday. |
If we can move this forward as "good enough ™️ " to not block launch and fast follow with small style fixes or code cleanup, I'd say that'd be ideal. |
I'm going to go ahead and approve based on ☝🏻. Just have a fast follow for change requests that weren't made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get this into the launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [2.54.0-beta.1](v2.53.1-beta.2...v2.54.0-beta.1) (2024-08-12) ### 🍕 Features * update DevCard design ([#3879](#3879)) ([979576d](979576d))
## [2.54.0](v2.53.0...v2.54.0) (2024-08-12) ### 🐛 Bug Fixes * add margin left to prevent overflow of nav item ([#3904](#3904)) ([c8b8ace](c8b8ace)) * contributor insight card orange dot no longer squished ([#3912](#3912)) ([01cb265](01cb265)) ### 🍕 Features * update DevCard design ([#3879](#3879)) ([979576d](979576d))
Description
Implements a new DevCard design that showcases OSCR and the user's contribution activity
Related Tickets & Documents
Closes #3872
Mobile & Desktop Screenshots/Recordings
Area.mp4
Arc.mp4
Arc2.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?