fix: add margin left to prevent overflow of nav item #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dun-sin
commented
Aug 9, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dun-sin
commented
Aug 9, 2024
|
Accepted the deploy preview and running CI/CD now. |
brandonroberts
approved these changes
Aug 12, 2024
brandonroberts
changed the title
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [2.53.1-beta.1](v2.53.0...v2.53.1-beta.1) (2024-08-12) ### 🐛 Bug Fixes * add margin left to prevent overflow of nav item ([#3904](#3904)) ([c8b8ace](c8b8ace))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [2.54.0](v2.53.0...v2.54.0) (2024-08-12) ### 🐛 Bug Fixes * add margin left to prevent overflow of nav item ([#3904](#3904)) ([c8b8ace](c8b8ace)) * contributor insight card orange dot no longer squished ([#3912](#3912)) ([01cb265](01cb265)) ### 🍕 Features * update DevCard design ([#3879](#3879)) ([979576d](979576d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the class
ml-2to the nav component to prevent the overflowRelated Tickets & Documents
fix #3889
Mobile & Desktop Screenshots/Recordings
before:
after:
brave_f7n92rcpCF.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?