fix: eslint warning "anchor-is-valid" #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted element in child 1, story 3
CorinaMurg
requested review from
nickytonline,
zeucapua and
brandonroberts
as code owners
👷 Deploy request for oss-insights pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
brandonroberts
approved these changes
Oct 25, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
## [2.64.1-beta.1](v2.64.0...v2.64.1-beta.1) (2024-10-25) ### 🐛 Bug Fixes * eslint warning "anchor-is-valid" ([#4181](#4181)) ([5b67103](5b67103))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the eslint-jsx-a11y warning "anchor-is-invalid" present in
components/atoms/ToggleGroup/toggle-group.stories.tsx. The "anchor-is-invalid" rule checks that all anchors are navigable elements.The purpose of the
CustomItemsstory inToggleGroupis to demonstrate how to use HTML elements or nested elements as children ofToggleGroup. The first child was initially an<a>element nested inside adiv, and the accessibility linter was complaining that thehrefvalue of#was invalid. Adding a validhrefvalue would have taken care of the warning, however we would still be left with a serious accessibility issue not covered by the linter.The children of the
ToggleGroupare tabs, so basically buttons. Having alinknestedinsidea button creates accessibility issues for screen reader users, as well low-vision users and those relying on voice control. This PR replaces the<a>element with a<span>. Ideally, a future PR will look into restricting the children ofToggleGroupto only non-interactive elements.Related Tickets & Documents
Fixes #4136
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
N/A
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?
(Sorry, just flew in from the 20th century. What is a good resource for gifs?)