feat: Working Nivo chart #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ogdev/chart-component-rebuild
✅ Deploy Preview for contributor-info ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdougie
commented
Jan 5, 2024
pages/[owner]/[repo]/index.tsx
Outdated
|
|
||
| if (!data && !error) { |
There was a problem hiding this comment.
This change is breaking the build. Failing when project tries to build pages that are undefined in the prCounts.ts
TypeError: Cannot read properties of undefined (reading 'forEach')
There was a problem hiding this comment.
nvm. I figured it out that prCounts file is duplicated and I was looking at the original, but there is one in the lib.
|
@OgDev-01 the build was failing and there we multiple Type errors (my errors). I wanted to get this app in a place where we can share a deploy preview so I went ahead and fix those in this PR. I saw you moved the files around but didn't get to deleting the original files. I deleted the duplicated prCounts since it was causing the build failure. |
open-sauced bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
## [1.2.0-beta.1](v1.1.0...v1.2.0-beta.1) (2024-01-05) ### 🍕 Features * Add a PR activity chart ([#19](#19)) ([9bac59a](9bac59a)) * spice up contributors pr chart styles ([#20](#20)) ([bdf937f](bdf937f)) * use v2 pr/search ([#16](#16)) ([f1f78ff](f1f78ff)) * Working Nivo chart ([#22](#22)) ([22c07a9](22c07a9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking over the PR from #20 to move things forward.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Steps to QA
Enter withastro/astro in the input field
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?