Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redirect not found page to homepage #8

Merged
merged 3 commits into from
Sep 17, 2022
Merged

feat: redirect not found page to homepage #8

merged 3 commits into from
Sep 17, 2022

Conversation

takanome-dev
Copy link
Contributor

@takanome-dev takanome-dev commented Sep 16, 2022 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Add a 404 page that redirects to the homepage

Related Tickets & Documents

Fixes #3

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 16, 2022 •
edited
Loading

❌ Deploy Preview for shimmering-puppy-475abf failed.

Name Link
🔨 Latest commit de6493f
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-puppy-475abf/deploys/6324f72b5e7c22000867c2b4

@netlify
Copy link

netlify bot commented Sep 16, 2022 •
edited
Loading

✅ Deploy Preview for contributor-info ready!

Name Link
🔨 Latest commit 4d1ebba
🔍 Latest deploy log https://app.netlify.com/sites/contributor-info/deploys/6325887d7221b800080dfe2a
😎 Deploy Preview https://deploy-preview-8--contributor-info.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot]
github-actions bot reviewed Sep 16, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@0-vortex
Copy link
Contributor

@takanome-dev https://beta.contributor.info is up now, you should be able to merge with beta and get a deploy preview going! 🍕

@takanome-dev
Copy link
Contributor Author

@0-vortex done ✔️

@0-vortex 0-vortex merged commit 9da5e11 into open-sauced:beta Sep 17, 2022
0-vortex
0-vortex reviewed Sep 17, 2022
View reviewed changes
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! 👍

github-actions bot pushed a commit that referenced this pull request Sep 17, 2022
@takanome-dev @open-sauced
chore(patch): release 1.0.1-beta.1 on beta channel [skip ci]
58bf57e 
### [1.0.1-beta.1](v1.0.0...v1.0.1-beta.1) (2022-09-17)

### 🧑‍💻 Code Refactoring

* improve redirect not found page and route ([#8](#8)) ([9da5e11](9da5e11)), closes [#3](#3)
@github-actions
Copy link

🎉 This PR is included in version 1.0.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@takanome-dev takanome-dev deleted the redirect-404-to-home branch September 17, 2022 21:22
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
@bdougie @open-sauced
chore(minor): release 1.1.0 [skip ci]
fd725f2 
## [1.1.0](v1.0.0...v1.1.0) (2022-09-27)

### 🧑‍💻 Code Refactoring

* improve redirect not found page and route ([#8](#8)) ([9da5e11](9da5e11)), closes [#3](#3)

### 🍕 Features

* Adds working search to home page ([#11](#11)) ([f88bf74](f88bf74)), closes [#4](#4)
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@0-vortex 0-vortex 0-vortex left review comments

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: force redirects for not found 404 to "/"
2 participants
@takanome-dev @0-vortex