Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript support and recommended extensions #420

Closed

Conversation

hichemfantar
Copy link

@hichemfantar hichemfantar commented Nov 19, 2024

Description

Introduce TypeScript support to the project, including necessary configuration files and type definitions for better development experience.
https://docusaurus.io/docs/typescript-support

Related Tickets & Documents

closes #424

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@hichemfantar hichemfantar requested a review from a team as a code owner November 19, 2024 13:02
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for saucedocs ready!

Name Link
🔨 Latest commit 9162e3c
🔍 Latest deploy log https://app.netlify.com/sites/saucedocs/deploys/673ca05897ede50008cb8bb0
😎 Deploy Preview https://deploy-preview-420--saucedocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • npm-shrinkwrap.json
  • package.json

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@adiati98
Copy link
Member

Hey @hichemfantar,
Thank you for taking on this! We appreciate your contribution. ✨

However, following our contributing guidelines, we will close this PR with below reasons:

  • You don't have an issue that accompanying this PR. We need to know in advance what changes you propose for us to make decision if we will proceed the changes.

Please read our contributing guidelines before you contribute to our repositories. 🙂

That being said, we are closing your other PRs. Please create issues and our team will triage them.

Thank you.

@hichemfantar
Copy link
Author

@adiati98 i created and linked the proper issue, feel free to reopen when approved

@hichemfantar hichemfantar changed the title feat: add TypeScript support and configuration files feat: add TypeScript support and recommended extensions Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: typescript support for codebase
2 participants