-
-
Notifications
You must be signed in to change notification settings - Fork 149
fix(search): navigation URL path change #506
Conversation
Changed the path name in navigating route so now after selection of the search result from the list the user will be navigated to correct page. fix #2423
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!!!! 🚀
A few linting errors it looks like: please also address those! Thanks!!
fixed liniting and type errors fix open-sauced#505
As soon as I type the letter
|
Yes @nickytonline the supabase env variables VITE_SUPABASE_URL and VITE_SUPABASE_API_KEY are not working correctly. I actually used the production supabase URL and API key ( from headers when you make requests ) to fix this issue 😁 |
Sorry for letting this one go stale @sourabpramanik. We have some updates that will make this PR not as useful. I am updating the URL here, but let me know if you want to continue the path of improving the experience on this project. |
Sure thing @bdougie |
This PR makes this not worth pursuing as is. We would need an entirely different approach for search. Most like something similar to app.opensauced.pizza, where we use the GitHub API directly. https://github.com/open-sauced/app/blob/beta/lib/hooks/useSearchRepos.ts |
Description
Changed the path name in navigating URL so now after selection of the search result from the list the user will be navigated to correct page.
And removing the filter in the dashboard won't lead the user to 404.
What type of PR is this? (check all applicable)
Related Tickets & Documents
This PR fixes both issues #505 and #2423 in open-sauced/app repo
Mobile & Desktop Screenshots/Recordings
Steps to QA
1.go to https://hot.opensauced.pizza/
2. type rust
3. wait for the results, click on the first one to select it, then press Enter to navigate
4. try removing filter now
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
NO
[optional] What gif best describes this PR or how it makes you feel?