This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
feat: enhance accessibilty and seo for hero section #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @sohaibchebah! Please read the contributing guidelines above. |
sohaibchebah
changed the title
sohaibchebah
changed the title
This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers understand more the semantic html feat open-sauced#530
sohaibchebah
changed the title
nickytonline
suggested changes
Aug 15, 2024
Comment on lines
+2
to
+3
| <section | ||
| aria-labelledby="hero-heading" |
There was a problem hiding this comment.
refactor (blocking): assistive technologies know how to pick up the header within the section, so no need for aria.
Suggested change
| <section | |
| aria-labelledby="hero-heading" | |
| <section |
There was a problem hiding this comment.
thanks a lot for the information 😊
| className="font-Lexend text-4xl md:text-5xl text-center text-lightSlate leading-tight tracking-tight" | ||
| id="hero-heading" |
There was a problem hiding this comment.
refactor (blocking): not required base on comment above.
Suggested change
| id="hero-heading" |
nickytonline
changed the title
|
This repo is being archived. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers understand more the semantic html
Related Tickets & Documents
Closes #530
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
N/A
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?