fix: Don't overwrite ldflags in justfile builds
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <john@opensauced.pizza>
nickytonline
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Ran just build-all then ./build/pizza-darwin-arm64 version and all good now.
=> [builder 2/6] WORKDIR /app 0.7s
=> [builder 3/6] COPY go.* ./ 0.0s
...
pizza-cli on fix-ldflags [$?] via 🐳 desktop-linux via 🐹 v1.23.0 took 43s
❯ ./build/pizza-darwin-arm64 version
Version: dev
Sha: 432207b6b2cbe7fa59ba936c8ab546a9cb9203bd
Built at: 2024-09-11-23:45:33
It did mention this though.
1 warning found (use docker --debug to expand):
- SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "POSTHOG_PUBLIC_API_KEY") (line 8)
I reject that suggestion haha 😂 the posthog public key isn't a secret thankfully, otherwise, yes, we'd want to handle it more securely |
Oh yeah, I guess it has no way of knowing if it's a public key or not. 😅 |
brandonroberts
approved these changes
Sep 12, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
## [1.4.1-beta.1](v1.4.0...v1.4.1-beta.1) (2024-09-12) ### 🐛 Bug Fixes * Don't overwrite ldflags in justfile builds ([#171](#171)) ([e024687](e024687))
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
## [1.5.0](v1.4.0...v1.5.0) (2024-09-16) ### 🐛 Bug Fixes * Config path prefers local dir vs. home dir ([#184](#184)) ([859446a](859446a)) * Don't overwrite ldflags in justfile builds ([#171](#171)) ([e024687](e024687)) ### 🍕 Features * Cut 2.0.0 release ([#193](#193)) ([278a833](278a833)) * pizza generate insight command ([#179](#179)) ([7315a1d](7315a1d)) * Update README docs ([#186](#186)) ([99328aa](99328aa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a small error that was causing the ldflags to get overwritten (one after another). More or less a
go buildcommand error.This also adds missing build-args for the docker container in the GitHub action. Date and sha might be abit more tricky to get into that action, but for now, the version is good enough
Related Tickets & Documents
Closes: #167 (cc @brandonroberts - I ended up going down a rabbit hole on this one, apologies)
Steps to QA
just build-all./build/pizza-darwin-arm64 versionand see the right version and shaTier (staff will fill in)