Feature: removes migrations in favor of OpenSauced API data model #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
approved these changes
Jul 31, 2023
|
Coming back to this since we have alignment on the data model in https://github.com/open-sauced/api/pull/225 This also probably needs a few doc updates on getting started with the API's database (or at least linking off to those instructions in the api repo) |
bdougie
approved these changes
Aug 8, 2023
- Adjusts SQL queries to conform to the data model used by OpenSauced
API.
- Adjusts hack/setup.sh to work with migration under hack/pizza.sql
- Adds a few small other fixes to ensure the hack/setup.sh script
works as intended
Signed-off-by: John McBride <john@opensauced.pizza>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hack/setup.shto work with migration underhack/pizza.sqlhack/setup.shscriptworks as intended
What type of PR is this? (check all applicable)
Related Tickets & Documents
Context: this is apart of https://github.com/open-sauced/api/issues/218 which will integrate this microservice within the OpenSauced API.
Mobile & Desktop Screenshots/Recordings
N/a
Added tests?
Added to documentation?
Still need to add docs
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?