Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package files glob pattern #21

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

Anush008
Copy link
Member

Description

This PR intends to resolve #20, by conditionally setting the blob patterns based on the NPM_PACKAGE_ROOT value to avoid committing dependency package files.
cc @0-vortex.

This was tested with demo releases here.
https://github.com/Anush008/ai/commit/08e9e0bdb6a695b65f28fb3a9e654e883ae8097c (Root directory release)
Anush008/xdg@2130982 (Sub directory release)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Resolves #20.

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

@Anush008 Anush008 requested review from bdougie and jpmcb and removed request for bdougie August 21, 2023 18:06
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-21 at 12 55 44 PM

👀 👏🏼 👏🏼

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates here @Anush008

@bdougie bdougie merged commit e6bf8c3 into open-sauced:main Aug 21, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: package files glob pattern matches dependency package files
3 participants