Skip to content

Commit

Permalink
Merge pull request #119 from oslabs-beta/v13-launch
Browse files Browse the repository at this point in the history
V13 launch
  • Loading branch information
choukevin612 authored Feb 8, 2024
2 parents 97dcd7d + 30484de commit 6452c5c
Show file tree
Hide file tree
Showing 7 changed files with 26,113 additions and 174 deletions.
2 changes: 2 additions & 0 deletions DEV_README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Run npm run dev twice if you do not manually run tsc to compile the files first.

- Migrated ERTabling to tableTabBar component to access the ERD because it lacked a parent compartment for prop drilling, hindering the addition of new features. Going forward, a more maintainable solution should be implemented like Redux or Zustand.

- Migrated ERTabling to tableTabBar component to access the ERD because it lacked a parent compartment for prop drilling, hindering the addition of new features. Going forward, a more maintainable solution should be implemented like Redux or Zustand.

<p><b>2. Isolating Database</b> <br> One of the biggest tasks that we tried but <b>did not finish</b> is isolating the concerns of each database type (DBType). The current application has multiple</p>
<code>if (database === DBType.postgres) {}<br>
else if (database === DBType.mysql) {}<br>
Expand Down
2 changes: 1 addition & 1 deletion __tests__/frontend/lib/unittesting.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('runSelectAllQuery', () => {
{ sqlString, selectedDb },
curDBType,
);
console.log(result);


expect(mockConnectionModel.connectToDB).toHaveBeenCalledWith('test', 'pg');
expect(mockConnectionModel.connectToDB).toHaveBeenCalledTimes(1);
Expand Down
1 change: 0 additions & 1 deletion backend/src/ipcHandlers/handlers/queryHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ export async function runSelectAllQuery(event, {sqlString, selectedDb}:SelectAll
try {
await connectionModel.connectToDB(selectedDb, curDBType);
const results = await queryModel.query(sqlString, [], curDBType);
console.log('good',results.rows)
return results?.rows
} catch (error) {
console.log(error, 'in runSelectAllQuery')
Expand Down
1 change: 0 additions & 1 deletion backend/src/utils/dummyData/dummyDataMain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export const getRandomInt = (min: number, max: number) => {
// helper function to generate random data based on a given column's data type
const generateDataByType = (columnObj: ColumnObj): string | number => {
let length;
console.log(columnObj.data_type);
// updated the new faker package so updated to follow proper documentation.
switch (columnObj.data_type) {
case 'smallint':
Expand Down
Loading

0 comments on commit 6452c5c

Please sign in to comment.