-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeeQR V13 #115
Merged
Merged
SeeQR V13 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Needed to make UI more intuitive. By moving the save and add column button to the end, users will be able to read their inputs on the Table Name field. ## Issues After making the changes, the Save button on TABLE_FOOTER is currently not functioning as expected. ## Changes Made Added TABLE_FOOTER to display after TABLE_HEADER and TABLE_FIELD. Removed unnecessary code that was not functional. # Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
# Commit Message
…ed-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
…ine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
…athyluong93@yahoo.com>
…athy Luong<cathyluong93@yahoo.com>
…leDetails. ## Changes Made # Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
Was able to prop drill appropriately database name starting from DbView to TableDetails, also able to display column names on Table View ## Changes Made Modified DbView, TableDetails, TablesTabBar to prop drill # Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
Co-authored-by: cyliang93 <cyliang93@users.noreply.github.com> Co-authored-by: Zoren <zorenal@users.noreply.github.com>
: fixed bugs and editors can now display selected query from query histories ##Changes Made: used new Set method to remove any duplicate queries and created if statement to check if editor.current does not exist then we will set the value to the updated sql ##Issues: selected query was not displaying it's history and duplicated were being made in the query history ##Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
##Co-authored-by: Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
…into zc-testing
##Co-authored-by: Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
##Changes Made ##Issues ##Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
##Changes Made: dbCRUDHandler.spec.ts ##Issues: dbAndTableInfo func causing a bottleneck during testing ##Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong <cathyluong93@yahoo.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
Co-authored-by: cyliang93 <cyliang93@users.noreply.github.com>
##Changes Made ##Issues ##Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
##Changes Made ##Issues ##Co-authored-by Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
##Co-authored-by: Co-authored-by: Elaine Wong <ewong1217@gmail.com> Co-authored-by: Cathy Luong <cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
Co-authored-by: user-byte123 <user-byte123@users.noreply.github.com> Co-authored-by: Cathy Luong <cathyluong93@yahoo.com>
Co-authored-by: Cathy Luong <cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
…ail.com> Co-authored-by: Cathy Luong <cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
Updated GIF for Query history # Co-authored-byi Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
Upgraded README # Co-authored-byi Co-authored-by: Cathy Luong<cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com> Co-authored-by: Kevin Chou <choukevin@berkeley.edu>
Co-authored-by: Cathy Luong <cathyluong93@yahoo.com> Co-authored-by: Zoren Labrador <zorenzal@gmail.com>
zorenal
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.