Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Dummy Data Algorithm #37

Merged
merged 6 commits into from
Sep 3, 2020
Merged

Integrating Dummy Data Algorithm #37

merged 6 commits into from
Sep 3, 2020

Conversation

mstronck
Copy link
Member

@mstronck mstronck commented Sep 3, 2020

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Needed to have the containerized postgres database utilize the dummy data algorithm.
  • Importing database files in splash screen and in modal code had useless setTimeouts.

Approach

  1. Appended to the bottom of main.ts the 'dummy_handler' channel which may be used in the future to scale DB's
  2. Declared the function dummyFunc which gets invoked immediately. This function spins up the hard coded dummy database upon application launch.
  3. We know that the dummy data algorithm is working because the developer can alter the number next to scale in the hard coded dummy data configuration object to which ever scale they like. Preferably ~1000.
  4. Commented out db.changeDB methods because tabs will be the way we switch between databases for launch. Should probably rename the redirectModal function in main.ts but I will keep the it the same name for the sake of merging at the time being. It will most likely be renamed within the hour.

Learning

-NA: No resources

Screenshot(s)

1000 rows requested
cc7dd2a4c65299aae7cf0c2a26a1afea
1000 Rows returned
d52591576c7b199087196c7f946ed7d1

Copy link
Contributor

@catherinechiu catherinechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@serenackuo serenackuo self-requested a review September 3, 2020 05:27
@muhammadtrad muhammadtrad requested review from muhammadtrad and removed request for serenackuo September 3, 2020 05:27
Copy link
Contributor

@muhammadtrad muhammadtrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@catherinechiu catherinechiu merged commit 5fcb15f into launch Sep 3, 2020
frakes413 added a commit to frakes413/SeeQR that referenced this pull request Oct 10, 2020
cindychau pushed a commit that referenced this pull request Feb 25, 2021
Completed MVP for AddNewDbModal and DuplicateNewDbModal
derekoko pushed a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants