Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bar, Line Chart and Tabs #39

Merged
merged 12 commits into from
Sep 3, 2020
Merged

Add Bar, Line Chart and Tabs #39

merged 12 commits into from
Sep 3, 2020

Conversation

catherinechiu
Copy link
Contributor

@catherinechiu catherinechiu commented Sep 3, 2020

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Users need a way to compare various previous query results between different schemas
  • Users need a way to add new schemas/databases
  • Users need an intuitive way to visualize the data from the results table
  • Users need an intuitive way to visualize data from the comparisons table
  • CurrentSchema in state is not being updated when executing a query

Approach

  • Create a line chart to compare the query label vs runtime of the results table
  • Create a bar chart to compare the query label vs runtime of the comparisons table
  • Add tabs to navigate to newly created schemas/databases
  • Add tabs to hold create multiple types of data in the history and comparisons table and bar chart
  • CurrentSchema property in state is now updated with asynchronous solution

Screenshot(s)

  • Tabs
    tabs
  • Bar Chart
    PR with bar chart
  • Line Chart
    PR with line chart
  • User interface at application launch
    pr empty
  • User interface with populated data
    PR with Scroll

Copy link
Member

@mstronck mstronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mstronck mstronck self-requested a review September 3, 2020 07:56
@catherinechiu catherinechiu changed the title Convert Upload Schema to Multiple Components Add Bar, Line Chart and Tabs Sep 3, 2020
Copy link
Member

@mstronck mstronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@muhammadtrad muhammadtrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!

@catherinechiu catherinechiu merged commit b888dbd into launch Sep 3, 2020
frakes413 pushed a commit to frakes413/SeeQR that referenced this pull request Oct 10, 2020
Graph color and refactor of compare file
cindychau pushed a commit that referenced this pull request Feb 25, 2021
derekoko pushed a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants