Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend #5

Merged
merged 16 commits into from
Aug 15, 2020
Merged

Frontend #5

merged 16 commits into from
Aug 15, 2020

Conversation

mstronck
Copy link
Member

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Start all team members off with a boilerplate file structure and set up dependencies and necessary frameworks within webpack.

Approach

Set up dev environment with HMR, react, and electron integration.

Screenshot(s)

Screen Shot 2020-08-15 at 11 24 48 AM

catherinechiu and others added 16 commits August 13, 2020 12:21
@catherinechiu
boilerplate: gitignore, webpack with ts functioning without errors
c8684b9
@catherinechiu
change tsconfig filee to test noImplicitAny: true
efb2924
@serenackuo
clean up master branch
60cebd6
@serenackuo
separate webpack config to dev and build - boilerplate basic function
9ec6935
@serenackuo
open electron app through dev mode, add separate html file for path
c64534e
@serenackuo
add spawn to trigger launch of electron in dev mode
89e7598
@catherinechiu
hot module working recompiling, but not updating correctly
b988235
@catherinechiu
deleted index.html file template and added CspHtmlWebpackPlugin and M…
209b0b4 
…iniCssExtractPlugin
@serenackuo
fix linking app component and hot reload in dev env
5dfc21b
@catherinechiu
added dev1 script to test
3d83178
@catherinechiu
not working hmr
3e3a263
@catherinechiu
hmr worksgit status
c67936e
@catherinechiu
hmr in dev mode works
e7a581e
@catherinechiu
clean up file structure
0fb3409
@catherinechiu
boilerplate is clean and refactored
ecd7a5d
@mstronck
Merge pull request #4 from catherinechiu/frontend
6216606 
Frontend
catherinechiu
catherinechiu reviewed Aug 15, 2020
View reviewed changes
Copy link
Contributor

@catherinechiu catherinechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

@catherinechiu catherinechiu self-requested a review August 15, 2020 19:04
@serenackuo serenackuo requested review from serenackuo and removed request for serenackuo August 15, 2020 19:04
catherinechiu
catherinechiu approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@catherinechiu catherinechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better!

serenackuo
serenackuo approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@serenackuo serenackuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@serenackuo serenackuo merged commit 9b6d580 into master Aug 15, 2020
frakes413 pushed a commit to frakes413/SeeQR that referenced this pull request Oct 1, 2020
@JustinD-A
Merge pull request open-source-labs#5 from JustinD-A/testing
6a362a8 
Front-end Testing and .sass Compile Bug Fix
chrisakinrinade added a commit that referenced this pull request Jan 7, 2021
@chrisakinrinade
Merge pull request #5 from jcourtner/pgstats
4594843 
Added database size to each database tab
cindychau pushed a commit that referenced this pull request Feb 25, 2021
@rlam108
Merge pull request #5 from Claudiohbsantos/format
cca26fd 
setup chores (backend eslint, tsconfig
JBradbeer pushed a commit that referenced this pull request Apr 28, 2022
@santosb93
Merge pull request #5 from oslabs-beta/bryan/deletecolumn
a730dbb 
Bryan/deletecolumn
Frynoceros pushed a commit that referenced this pull request Aug 4, 2022
@fred-jeong
Merge pull request #5 from oslabs-beta/ian/dbtype-setting
e9a245c 
Ian/dbtype setting
Hiya-its-Aya pushed a commit that referenced this pull request Feb 23, 2023
@paulinekpn
Merge pull request #5 from oslabs-beta/aya
f784836 
Aya to dev
haemie pushed a commit that referenced this pull request Jul 7, 2023
@juzi3
Merge pull request #5 from oslabs-beta/feature/newSbBtn
8facbe0 
Added sidebar button and new tab for login
derekoko added a commit that referenced this pull request Aug 24, 2023
@derekoko
Merge pull request #5 from oslabs-beta/derek/depends
769bd34 
Derek/depends
lovelyjoy1991 pushed a commit that referenced this pull request Jun 5, 2024
@michaelma7
Merge pull request #5 from oslabs-beta/ting/redux-toolkit
4bef71f 
`feat : Transitioning from context API to Redux toolkit for state management, not finished`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catherinechiu catherinechiu catherinechiu approved these changes

@serenackuo serenackuo serenackuo approved these changes

@FrankNorton32 FrankNorton32 Awaiting requested review from FrankNorton32

@muhammadtrad muhammadtrad Awaiting requested review from muhammadtrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstronck @catherinechiu @serenackuo