added progress bar #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this 'progress' parameter required, or can it be optional? |
|
Whoops, I just made it optional! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
I eventually went with a solution that involved polling and reading from shared memory. Here's a high level overview:
Progress.new()struct in the web-worker and pass that tocomputeParameters.pointer()method to get the memory address ofProgressfor Javascript's usage.itemsProcessedanditemsTotalto the memory address ofProgress.The Javascript API for the Progress functionality is... not good, since the memory has to be instantiated in the worker thread, passed to Rust, and also passed to the main JS thread. I'm open to ideas on how to make it better!