computeWeights takes FSRSItems. Added computeWeightsAnki
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Btw, do you mind being a member of my organization and moving this repository into open-spaced-repetition? |
|
Sure! Shoutout to this comment several months ago. I'm not confident this project is "usable" yet - I'm unsure what APIs should be exposed, but they should be simple to implement as I work through things. |
|
I have sent an invitation to you. When you accept it, you will be able to move the repository into our organization. Then I will assign the admin role of this repo to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
@L-M-Sherlock what do you think of this
computeWeightsAPI? In your issue/commit you pass FSRSItems as a string which you deserialize. Instead, mycomputeWeightstakes 3[u32]s, which I believe is a performance enhancement since it minimizes (de)serialization costs. I believe we should try to optimize perf here since the number of FSRSItems may get very large.