-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/FSRS-5 #114
Feat/FSRS-5 #114
Conversation
I think that instead of aiming for "release FSRS-5 in [month]", we should aim for "release FSRS-5 when RMSE decreases by at least 10% relative to FSRS-4.5" |
I'm afraid FSRS-5 will be never released if we need to achieve that target.
I think it's a good time to release FSRS-5. |
With all due respect, I don't understand why you feel the need to release a new version if it's barely an improvement compared to the previous version. I firmly believe that we should aim for at least 10%. More would be better, of course. To me, 10% seems like the bare minimum; below that point, it's just not worth bothering with releasing a new version. |
@user1823 out of curiosity, what's your opinion? |
As the algorithm improves, the scope for further improvement decreases. So, aiming for a 10% improvement every time is not feasible. If the algorithm is going to consider short-term reviews now, I believe that this is a significant change and the update deserves to be called v5. |
I noticed that there is a change in the |
Makes sense. I agree that we don't need to rush through the release. Having longer intervals between the releases means that
|
OK. I have some criteria for the ideas:
|
That's gonna be hard.
Does that mean that my new definition of D (based on R) is automatically disqualified?
What do you mean exactly? |
If your new definition of D is out of the range 1~10, it would be rejected.
The user could use the new parameters without rescheduling all their cards. |
This one will always be satisfied, no? I mean, the user will have to click "Optimize" to obtain new parameters, but won't have to reschedule. How would it be different? |
Typo, it should be |
Sometime the user may press |
Why not just estimate 4 values of answer button probabilities, but for learning and re-learning steps? |
It's computing-expensive and hard to model. |
Is it? It's just another numpy array (and whatever equivalent of a numpy array is used in Rust), similar to |
The user may not only press once. The short-term rating sequence would be |
bbb861b
to
bc5902e
Compare
candidate:
I plan to release FSRS-5 in June.